Skip to content

ci(benchmarking): Added benchmarking stage #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 23, 2019

Conversation

msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Jul 5, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jul 5, 2019

Coverage Status

Coverage remained the same at 99.711% when pulling f97f3d8 on sohail/updatedscripttest into 7973aa8 on master.

@msohailhussain msohailhussain changed the title ci(benchmarking): Do not merge -- Testing only ci(benchmarking): Added benchmarking stage Jul 11, 2019
@yasirfolio3 yasirfolio3 reopened this Jul 12, 2019
@yasirfolio3 yasirfolio3 reopened this Jul 12, 2019
@yasirfolio3 yasirfolio3 reopened this Jul 12, 2019
@yasirfolio3 yasirfolio3 reopened this Jul 12, 2019
.travis.yml Outdated
stage: 'Benchmarking Tests'
env: SDK=python REPO_SLUG=Benchmarking
script:
- "$HOME/travisci-tools/trigger-script-with-status-update.sh yasir/bench-exp-support"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the yasir/bench-exp-support is for testing right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the custom branch and merge in now right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, about to remove.

.travis.yml Outdated
@@ -17,7 +17,8 @@ after_success:
# Linting and Integration tests need to run first to reset the PR build status to pending.
stages:
- 'Linting'
- 'Integration tests'
- 'Integration Tests'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis gui will lowercase this for you even though you specify upppercase... it's annoying :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah realized, will change it.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 968a54e into master Jul 23, 2019
@oakbani oakbani deleted the sohail/updatedscripttest branch September 24, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants