-
Notifications
You must be signed in to change notification settings - Fork 36
ci(benchmarking): Added benchmarking stage #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.travis.yml
Outdated
stage: 'Benchmarking Tests' | ||
env: SDK=python REPO_SLUG=Benchmarking | ||
script: | ||
- "$HOME/travisci-tools/trigger-script-with-status-update.sh yasir/bench-exp-support" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the yasir/bench-exp-support is for testing right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the custom branch and merge in now right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, about to remove.
.travis.yml
Outdated
@@ -17,7 +17,8 @@ after_success: | |||
# Linting and Integration tests need to run first to reset the PR build status to pending. | |||
stages: | |||
- 'Linting' | |||
- 'Integration tests' | |||
- 'Integration Tests' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
travis gui will lowercase this for you even though you specify upppercase... it's annoying :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah realized, will change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.