Skip to content

fix(config-manager): Updated polling interval condition. #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2019
Merged

fix(config-manager): Updated polling interval condition. #208

merged 4 commits into from
Sep 12, 2019

Conversation

rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Sep 5, 2019

Summary

  • Update condition for using default update_interval when polling files.

@rashidsp rashidsp requested a review from a team as a code owner September 5, 2019 13:38
aliabbasrizvi
aliabbasrizvi approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@coveralls
Copy link

coveralls commented Sep 6, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.001%) to 97.701% when pulling 07c43f5 on rashid/polling_interval into 57c1c32 on rashid/closeable_optimizely.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 97.701% when pulling bdcaf64 on rashid/polling_interval into 1916fc3 on rashid/closeable_optimizely.

@msohailhussain
Copy link
Contributor

Please update readme.md for valid polling interval.

@msohailhussain
Copy link
Contributor

Please update readme.md for polling interval.

@msohailhussain msohailhussain self-requested a review September 6, 2019 17:14
msohailhussain
msohailhussain reviewed Sep 9, 2019
View reviewed changes
optimizely/config_manager.py
# If polling interval is less than minimum allowed interval then set it to default update interval.
if update_interval < enums.ConfigManager.MIN_UPDATE_INTERVAL:
# If polling interval is less than or equal to 0 then set it to default update interval.
if update_interval <= 0:
self.logger.debug('update_interval value {} too small. Defaulting to {}'.format(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update_interval value is not greater than zero, Defaulting to {} value. @aliabbasrizvi WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think current message is fine.

@aliabbasrizvi aliabbasrizvi merged commit 4480402 into rashid/closeable_optimizely Sep 12, 2019
@aliabbasrizvi aliabbasrizvi deleted the rashid/polling_interval branch September 12, 2019 05:31
@oakbani oakbani restored the rashid/polling_interval branch September 12, 2019 12:27
@oakbani oakbani mentioned this pull request Sep 12, 2019
Merged
@oakbani oakbani deleted the rashid/polling_interval branch September 12, 2019 13:30
mjc1283 pushed a commit that referenced this pull request Sep 16, 2019
@oakbani @mjc1283
update: update polling interval. (#209)
547a13c 
Replica of #208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

@msohailhussain msohailhussain msohailhussain left review comments

Assignees

@rashidsp rashidsp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rashidsp @coveralls @msohailhussain @aliabbasrizvi @mariamjamal94