Skip to content

Update setup.py #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emielrv wants to merge 2 commits into from
Closed

Update setup.py #221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0e622c
Update setup.py
emielrv Nov 13, 2019
de91f50
Merge branch 'master' into master
emielrv Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
with open(os.path.join(here, 'README.md')) as _file:
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have to make the change here as well?

Copy link
Author

@emielrv emielrv Nov 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, to be honest I don't know what would be a best practice here. I know only changing it here will solve the problem, since the rest doesn't have these special characters. But maybe it is a best practice to change it everywhere.

Copy link
Contributor

@aliabbasrizvi aliabbasrizvi Nov 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the change you made will not work with Python 2.7.

We can try updating the content in CHANGELOG itself.

README = _file.read()

with open(os.path.join(here, 'CHANGELOG.md')) as _file:
with open(os.path.join(here, 'CHANGELOG.md'), encoding='utf-8') as _file:
CHANGELOG = _file.read()

about_text = (
Expand Down