Skip to content

feat: get_optimizely_config API #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 6, 2020
Merged

feat: get_optimizely_config API #226

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b46b95e
Structure Optimizely Config
oakbani Dec 5, 2019
0f2cf5a
Some more work
oakbani Dec 6, 2019
e2cccb8
Works on this
oakbani Dec 6, 2019
4deaf60
Optimized by lookup maps
oakbani Dec 6, 2019
6f2a79f
Add comments and unit tests
oakbani Dec 9, 2019
b7e25fb
Merge branch 'master' into oakbani/optimizely-config
oakbani Dec 9, 2019
7709dff
address comments
oakbani Dec 10, 2019
7a9cb08
tests: unit tests
oakbani Dec 10, 2019
15bcb76
address comments
oakbani Dec 12, 2019
720d350
fix: lint
oakbani Dec 12, 2019
ec4f84f
Merge remote-tracking branch 'remotes/origin/master' into oakbani/opt…
oakbani Dec 16, 2019
caad32d
validate project config
oakbani Dec 16, 2019
1704ada
Merge remote-tracking branch 'remotes/origin/master' into oakbani/opt…
oakbani Dec 31, 2019
dcc7389
nit
oakbani Dec 31, 2019
19bb7fd
headers
oakbani Dec 31, 2019
2aa243c
Merge remote-tracking branch 'remotes/origin/master' into oakbani/opt…
oakbani Jan 3, 2020
a95c669
refact: nits
oakbani Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tests/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,14 +182,12 @@ def setUp(self, config_dict='config_dict'):
{
'id': '122239',
'key': 'control',
'featureEnabled': True,
'variables': [{'id': '155551', 'value': '42.42'}],
'variables': [],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed these since this is not a feature experiment so shouldn't have these props.

},
{
'id': '122240',
'key': 'variation',
'featureEnabled': True,
'variables': [{'id': '155551', 'value': '13.37'}],
'variables': [],
},
],
},
Expand Down
Loading