Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): Preparing for 3.4.1 release #240

Merged
merged 1 commit into from
Mar 19, 2020
Merged

chore(release): Preparing for 3.4.1 release #240

merged 1 commit into from
Mar 19, 2020

Conversation

aliabbasrizvi
Copy link
Contributor

Release to address one of the issues in #232

@aliabbasrizvi aliabbasrizvi requested a review from a team as a code owner March 19, 2020 05:44
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.746% when pulling 3cb524b on ali/prep_for_release into 0c9bf2a on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.746% when pulling 3cb524b on ali/prep_for_release into 0c9bf2a on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.746% when pulling 3cb524b on ali/prep_for_release into 0c9bf2a on master.

@aliabbasrizvi aliabbasrizvi removed their assignment Mar 19, 2020
mikeproeng37
mikeproeng37 approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliabbasrizvi aliabbasrizvi merged commit 167758d into master Mar 19, 2020
@aliabbasrizvi aliabbasrizvi deleted the ali/prep_for_release branch March 19, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliabbasrizvi @coveralls @mikeproeng37