wrong variation issue fix #346
Conversation
| variation.variables, 'id', entities.Variation.VariableUsage | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
Too many blank lines between code, should be removed to follow lint.
| @@ -0,0 +1,67 @@ | |||
| import json | |||
There was a problem hiding this comment.
Looks like this isnt used. Can be deleted.
| from optimizely import optimizely, decision_service | ||
| from optimizely.optimizely_user_context import OptimizelyUserContext | ||
| from optimizely.user_profile import UserProfileService | ||
|
|
There was a problem hiding this comment.
Please cleanup imports as many are not used.
| @@ -362,8 +391,8 @@ def get_variation_from_id(self, experiment_key, variation_id): | |||
| Object representing the variation. | |||
| """ | |||
|
|
|||
| variation_map = self.variation_id_map.get(experiment_key) | |||
|
|
|||
| #variation_map = self.variation_id_map.get(experiment_key) | |||
There was a problem hiding this comment.
Please remove commented code
|
|
||
| self.audience_id_map = self._deserialize_audience(self.audience_id_map) | ||
| for group in self.group_id_map.values(): | ||
| experiments_in_group_key_map = self._generate_key_map(group.experiments, 'key', entities.Experiment) | ||
| for experiment in experiments_in_group_key_map.values(): | ||
| experiment.__dict__.update({'groupId': group.id, 'groupPolicy': group.policy}) | ||
| self.experiment_key_map.update(experiments_in_group_key_map) | ||
| experiments_in_group_id_map = self._generate_key_map(group.experiments, 'id', entities.Experiment) |
There was a problem hiding this comment.
To avoid confusion maybe we should rename this function or create a new one for ids.
| @@ -68,6 +70,7 @@ def __init__(self, datafile, logger, error_handler): | |||
|
|
|||
| # Utility maps for quick lookup | |||
| self.group_id_map = self._generate_key_map(self.groups, 'id', entities.Group) | |||
| self.experimentID_map = self._generate_key_map(self.mapexperiment, 'id', entities.Experiment) | |||
There was a problem hiding this comment.
We shouldn't mix camel cases with snake_case
There was a problem hiding this comment.
Why experiment's can't be passed? what's the need of mapexperiment?
| rollout_rule = project_config.get_experiment_from_key(rollout.experiments[idx].get('key')) | ||
|
|
||
| rollout_rule = project_config.get_experiment_from_id(rollout.experiments[idx].get('id')) | ||
| # rollout_rule = optimizely.entities.Experiment(**rollout.experiments[idx]) |
|
Changes are fine as well. |
| @@ -56,6 +57,7 @@ def __init__(self, datafile, logger, error_handler): | |||
| self.environment_key = config.get('environmentKey', None) | |||
| self.groups = config.get('groups', []) | |||
| self.experiments = config.get('experiments', []) | |||
| self.mapexperiment = copy.deepcopy(self.experiments) | |||
There was a problem hiding this comment.
this doesn't look ok to me.
There was a problem hiding this comment.
Found some other issues as well with test cases. working through now.
Wrong variation and rule
The “why”, or other context.
Test plan
testing the data files on different scnerios
Issues