Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9510]: Implements a warning log for polling interval below 30s #428

Merged
merged 2 commits into from
Jul 18, 2023
Merged

[FSSDK-9510]: Implements a warning log for polling interval below 30s #428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d61c41e
Implements a warning log for polling interval below 30s
yasirfolio3 Jul 18, 2023
5a3fd20
cleanup.
yasirfolio3 Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions optimizely/config_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,11 @@ def set_update_interval(self, update_interval: Optional[int | float]) -> None:
)
update_interval = enums.ConfigManager.DEFAULT_UPDATE_INTERVAL

if update_interval < 30:
self.logger.warning(
'Polling intervals below 30 seconds are not recommended.'
)

self.update_interval = update_interval

def set_blocking_timeout(self, blocking_timeout: Optional[int | float]) -> None:
Expand Down