[GR-61448] Include Compilation ID in truffle compilation logs. #10549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into jchaloup/GR-61448/CompIdInTruffleCompLogs
… id logging work for libgraal and isolated truffle compiler on SVM; add the compilation id also to the truffle compilation JFR logs.
oracle-contributor-agreement
bot
added
the
OCA Verified
JohnTortugo
reviewed
Feb 28, 2025
|
|
||
| import com.oracle.truffle.compiler.hotspot.libgraal.TruffleToLibGraal; | ||
|
|
||
| final class TruffleToLibGraalCalls2 { |
There was a problem hiding this comment.
@jchalou - Out of curiosity: why do we need a separate file for this method?
There was a problem hiding this comment.
This is because Truffle has to be compatible also with libgraal that does not have the getCompilationId method entry point. LibGraalTruffleCompilationSupport registers the native methods is a way that either registers all the native methods in a class or none at all, and so the ones that are not required to be there have to be in their separate classes (for now, we do plan to introduce some more sophisticated methodology in the future).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.