Fix bug in JFR type repository #10749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
2 tasks
|
Hi @roberttoyonaga, can you please make the commit message more descriptive? Thanks |
roberttoyonaga
force-pushed
the
clojure-10742
branch
from
9fe8e5d to
2a8e70d
Compare
|
I updated the commit message. Note that one GHA is failing with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the bug reported by: #10742
The problem was that, for each class used during the epoch, we only visited its module's classloader (if the class' package and it's module were both non null). However, later on when serializing classes, we attempt to write the class' classloader. This classloader is never explicitly visited so may not have been processed.