[GR-75575] Check for invalid IsolateThread in AbstractStackFrameSpliterator. - #14269
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem to be fixed
ContinuationSpliterator could keep using a stack-allocated JavaStackWalk pointer after virtual-thread carrier migration, causing writes into the old carrier thread’s stack.
implemented fix and AI review
For the specific bug described in GR-75575, the fix is complete.
The vulnerable condition is: a heap object (ContinuationSpliterator) keeps a pointer to stack-allocated state (JavaStackWalk walk), and later uses it after execution has moved to another carrier/isolate thread. The only safe invariant is “this spliterator may only be advanced by the isolate thread that created it.”
That is exactly what the patch enforces:
Why it feels small: StackFrameSpliterator already had the same guard. The bug is not a deep algorithmic flaw in continuation walking; it is an asymmetry between the current-stack and stored-continuation spliterator implementations.
Champion Reviewer
@"peter.hofer@oracle.com"