FIX: Record fast accessor method dependency - #14319
Open
JohnTortugo wants to merge 1 commit into
Open
Conversation
Fast accessor inlining bypasses the nested parser that records methods used during compilation. Record the accessor so JVMTI class redefinition invalidates callers containing its inlined body.
Contributor
Author
|
/add contributor Ben Taylor (benty) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Record accessor methods handled by BytecodeParser.tryFastInlineAccessor in the graph鈥檚 method dependency list.
Problem
The fast accessor inlining path emits a field load directly instead of creating a nested BytecodeParser. As a result, it bypasses the graph.recordMethod(method) call normally performed by BytecodeParser.build().
When JVMTI class redefinition or retransformation is enabled, HotSpot converts the recorded methods into evol_method dependencies. Without the accessor in this list, retransformation of its declaring class does not invalidate compiled
callers containing its inlined body.
This can leave stale compiled code active. The issue was reproduced using Mockito鈥檚 inline mock maker:
Fix
Call graph.recordMethod(targetMethod) when the fast accessor path successfully inlines a getter. This restores the dependency that would have been recorded by the nested parser.
Add a regression test verifying that a fast-inlined accessor is present in StructuredGraph.getMethods().
Testing
Contributor Checklist