[GR-74135] Improve Java Main Class detection for abstract classes. - #14326
Merged
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #13150
馃
This change fixes native-image main-entry handling for inherited instance main methods. For instance-main entrypoints, it now instantiates the configured concrete main class instead of the method鈥檚 declaring class.
To support that cleanly, main-class and main-method resolution are unified in guest-side BuildTimeSupport, which now returns both values together as MainEntryPointInfo. NativeImageGeneratorRunner consumes that result instead of trying to reconstruct main-class/module resolution on the hosted side. This avoids duplicated resolution logic and keeps class/module lookup and related error handling in the guest context, where that logic already belongs.
The change also updates the web-image main-support plumbing to pass through the configured main class with the same API shape.