[GR-79039] Restore aggregate resource filesystem lookup. - #14327
Open
graalvmbot wants to merge 1 commit into
Open
[GR-79039] Restore aggregate resource filesystem lookup.#14327graalvmbot wants to merge 1 commit into
graalvmbot wants to merge 1 commit into
Conversation
Treat bare resource:/ filesystems as aggregate views instead of binding them to concrete root zero. Aggregate lookups select the first available resource variant, preserving legacy ClassLoader lookup behavior, while root-qualified resource URIs remain strict. Resolve aggregate paths back to the concrete root that supplied the selected variant when creating URIs. Keep directory traversal consistent with the aggregate view and add coverage for resources contributed by a different classpath root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resource:/filesystems as aggregate views instead of binding them to concrete root 0.Motivation
Preserving resource roots caused an unqualified resource filesystem to inherit concrete root 0. As a result, a lookup failed when the requested resource was contributed by another classpath root. Bare
resource:/filesystems historically provide aggregate, first-match behavior, while explicitly root-qualified resource URIs must remain isolated.Fixes #13920
Testing
mx buildmx checkstylemx native-unittest com.oracle.svm.test.NativeImageResourceFileSystemProviderTestmx native-unittest com.oracle.svm.test.NativeImageResourceTest