Skip to content

fix error logging and custom retry #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/common/lib/retrier.ts
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ export class GenericRetrier {
requestEndpoint: endpoint,
troubleshootingPage: `See ${TROUBLESHOOT_URL} for help troubleshooting this error, or contact support and provide this full error message.`
};
shouldBeRetried = true;
shouldBeRetried = this.retryConfiguration.retryCondition(errorObject);
}
let currentTime = new Date().getTime();
let timeElapsed = currentTime - timestamp.getTime();
Expand All @@ -268,7 +268,7 @@ export class GenericRetrier {
const delayTime = this.retryConfiguration.delayStrategy.delay(waitContext);
waitContext.attemptCount++;
console.warn(
`Request failed with Exception : ${lastKnownError}\nRetrying request -> Total Attempts : ${waitContext.attemptCount}, Retrying after ${delayTime} seconds...`
`Request failed with Exception : ${lastKnownError}\nRetrying request -> Total Attempts : ${waitContext.attemptCount}, Retrying after ${delayTime} seconds...`,lastKnownError
);
await delay(delayTime);
GenericRetrier.refreshRequest(request);
Expand Down