Skip to content
This repository was archived by the owner on Jun 23, 2020. It is now read-only.

Don't rely on storage class names to dispatch custom logic #131

Closed
owainlewis opened this issue Jun 8, 2018 · 2 comments
Closed

Don't rely on storage class names to dispatch custom logic #131

owainlewis opened this issue Jun 8, 2018 · 2 comments
Assignees
@harveylowndes
Labels
bug enhancement

Comments

@owainlewis
Copy link
Member

owainlewis commented Jun 8, 2018 •
edited
Loading

We currently rely on the name of a storage class to dispatch logic (oci-ext3 etc). We should change this to look at the storage class provisioner parameter because the names of storage classes should be independent of any underlying logic.
@harveylowndes harveylowndes self-assigned this Jun 12, 2018
This was referenced Jun 12, 2018
Closed
Closed
@harveylowndes harveylowndes mentioned this issue Jun 25, 2018
Closed
@jhorwit2
Copy link
Member

+1

This makes storage classes largely useless. For example, storage classes should be able to define mount options, which may not apply to all PVs created; however, because we force names of storage classes we can't create multiple.

@MadalinaPatrichi
Copy link
Member

Fixed in: #154

rjtsdl pushed a commit to rjtsdl/oci-volume-provisioner that referenced this issue Dec 20, 2018
@garthy @owainlewis
Config for Wercker release (oracle#131)
9419964 
* Remove unused pod file
* Clean makefile to add version/build
* Add checks to all target, verbose build
* Configure for release
* Add release process and content type
* Move copy to step
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@harveylowndes harveylowndes

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@owainlewis @MadalinaPatrichi @jhorwit2 @harveylowndes