This repository was archived by the owner on Jun 23, 2020. It is now read-only.
Support using symlinks to find correct driver #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2018 15:28
harveylowndes
force-pushed
the
symlink-flexvolume-driver-provisioner
branch
from
61a875b to
28094a3
Compare
harveylowndes
force-pushed
the
symlink-flexvolume-driver-provisioner
branch
from
5caac59 to
67e0bd5
Compare
harveylowndes
force-pushed
the
symlink-flexvolume-driver-provisioner
branch
from
7377b02 to
26e9c2c
Compare
prydie
suggested changes
Jun 18, 2018
cmd/oci/main.go
Outdated
| flexvolume.ExecDriver(&driver.OCIFlexvolumeDriver{}, os.Args) | ||
|
|
||
| drivers := map[string]flexvolume.Driver{ | ||
| "oci-bvs": &driver.OCIFlexvolumeDriver{}, |
There was a problem hiding this comment.
I suggest we use a registration mechanism for drivers like in the CCM's RegisterCloudProvider().
pkg/flexvolume/flexvolume.go
Outdated
| @@ -82,26 +86,6 @@ type Driver interface { | |||
| Unmount(mountDir string) DriverStatus | |||
| } | |||
|
|
|||
| // ExitWithResult outputs the given Result and exits with the appropriate exit | |||
| // code. | |||
| func ExitWithResult(result DriverStatus) { | |||
There was a problem hiding this comment.
Whilst hoisting ExitWithResult out of ExecDriver is a good idea, I don't see where you've re-implemented outputting the JSON to stdout. I'd suggest keeping this code and calling it from main.go.
pkg/flexvolume/flexvolume_test.go
Outdated
| bak := out | ||
| out = new(bytes.Buffer) | ||
| defer func() { out = bak }() | ||
| status := ExecDriver(map[string]Driver{"oci-bvs": mockFlexvolumeDriver{}}, |
There was a problem hiding this comment.
nit: personally find the following more readable:
status := ExecDriver(
map[string]Driver{"oci-bvs": mockFlexvolumeDriver{}},
[]string{"oci", "getvolumename", defaultTestOps},
)
pkg/flexvolume/flexvolume.go
Outdated
| @@ -143,127 +144,143 @@ func processOpts(optsStr string) (Options, error) { | |||
|
|
|||
| // ExecDriver executes the appropriate FlexvolumeDriver command based on | |||
| // recieved call-out. | |||
| func ExecDriver(driver Driver, args []string) { | |||
| func ExecDriver(drivers map[string]Driver, args []string) DriverStatus { | |||
There was a problem hiding this comment.
I suggest we implement the driver selection logic elsewhere and then pass it into ExecDriver as before rather than overloading ExecDriver.
harveylowndes
force-pushed
the
symlink-flexvolume-driver-provisioner
branch
3 times, most recently
from
1ce1c73 to
fbf6928
Compare
harveylowndes
force-pushed
the
symlink-flexvolume-driver-provisioner
branch
from
fbf6928 to
c696bfd
Compare
Update image name
…acle/oci-flexvolume-driver into symlink-flexvolume-driver-provisioner
added 18 commits
June 21, 2018 12:12
…acle/oci-flexvolume-driver into symlink-flexvolume-driver-provisioner
…ume-driver yaml manifest
…acle/oci-flexvolume-driver into symlink-flexvolume-driver-provisioner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses oracle/oci-volume-provisioner#131
The volume provisioner has been patched to now not use names to dispatch custom logic. A storage class can now use it's provisioner property to determine what driver should be used. At the moment only block volume storage is supported
provisioner: oracle.com/oci-bvswith aim that file storage will soon be supported also oracle/oci-volume-provisioner#90. Backwards compatible so that existing storage classes usingprovisioner: oracle.com/ociwill default to using the block volume storage however this should be marked as deprecated and removed in a future release.