Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(referrers): delete manifest with subject #174
base: main
Are you sure you want to change the base?
feat(referrers): delete manifest with subject #174
Changes from all commits
e3e1217
846e173
7fca0cb
ec93662
7809549
c7e4418
a6d552f
685ab70
1b9ade3
5041592
c26ccb6
ddbf048
d6e8499
cf431f0
50e696e
856c0ef
fcb121e
2b24e07
7df36ca
36a428f
1813869
878535c
4bee2cc
c848ed2
a7460f3
20dcda9
d7eb9b5
dfc538d
ff334ca
53f8e12
b13de61
c5d222a
21c714a
a23d7eb
d5c38b9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 208 in src/OrasProject.Oras/Registry/Reference.cs
src/OrasProject.Oras/Registry/Reference.cs#L207-L208
Check warning on line 32 in src/OrasProject.Oras/Registry/Remote/ManifestStore.cs
Check warning on line 32 in src/OrasProject.Oras/Registry/Remote/ManifestStore.cs
Check warning on line 309 in src/OrasProject.Oras/Registry/Remote/ManifestStore.cs
Check warning on line 309 in src/OrasProject.Oras/Registry/Remote/ManifestStore.cs
Check warning on line 422 in src/OrasProject.Oras/Registry/Remote/ManifestStore.cs
Check warning on line 422 in src/OrasProject.Oras/Registry/Remote/ManifestStore.cs
Check warning on line 463 in src/OrasProject.Oras/Registry/Remote/ManifestStore.cs
src/OrasProject.Oras/Registry/Remote/ManifestStore.cs#L463
Check warning on line 468 in src/OrasProject.Oras/Registry/Remote/ManifestStore.cs
src/OrasProject.Oras/Registry/Remote/ManifestStore.cs#L468
Check warning on line 470 in src/OrasProject.Oras/Registry/Remote/ManifestStore.cs
src/OrasProject.Oras/Registry/Remote/ManifestStore.cs#L470
Check warning on line 387 in src/OrasProject.Oras/Registry/Remote/Repository.cs
src/OrasProject.Oras/Registry/Remote/Repository.cs#L387
Check warning on line 398 in src/OrasProject.Oras/Registry/Remote/Repository.cs
src/OrasProject.Oras/Registry/Remote/Repository.cs#L397-L398
Check warning on line 403 in src/OrasProject.Oras/Registry/Remote/Repository.cs
src/OrasProject.Oras/Registry/Remote/Repository.cs#L402-L403
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we await this function and make
PingReferrers
async? But async calls are not allowed within thelock
statement. We can try SemaphoreSlim.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
SemaphoreSlim
does not seem right either. We need to consider a lock-free version.