OSAC-1029: Multi-NIC networking design for VMs and bare metal#64
Conversation
|
Warning Review limit reached
More reviews will be available in 37 minutes and 36 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a new ChangesMulti-NIC Networking Enhancement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
danmanor
force-pushed
the
multi-nic-design
branch
from
c4d7f82 to
2e549e7
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
enhancements/unified-networking/README.md (1)
601-620: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winUpdate proto definitions to reflect the
primaryfield introduced by the Multi-NIC Networking enhancement.The unified-networking document shows
ComputeNetworkAttachment(lines 601–608) andBareMetalNetworkAttachment(lines 613–621) without theprimaryfield. However, the new Multi-NIC Networking enhancement proposes adding abool primaryfield to both types. Readers of this document alone will see incomplete proto definitions.Either:
- Preferred: Update the proto definitions here to include the
primaryfield and cross-reference the Multi-NIC Networking doc for the operational semantics.- Alternative: Add a note next to each proto definition stating that it is extended by the Multi-NIC Networking enhancement.
This ensures proto definitions are authoritative and complete in the base unified-networking document.
Proposed fix (Option 1): Update proto definitions
message ComputeNetworkAttachment { string subnet = 1; // Subnet ID, required, immutable repeated string security_groups = 2; // SecurityGroup IDs, optional, mutable + bool primary = 3; // optional, default false; see Multi-NIC Networking enhancement }message BareMetalNetworkAttachment { string subnet = 1; // Subnet ID, required, immutable repeated string security_groups = 2; // SecurityGroup IDs, optional, mutable string interface = 3; // optional, immutable: physical interface identifier from BMaaS + bool primary = 4; // optional, default false; see Multi-NIC Networking enhancement }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@enhancements/unified-networking/README.md` around lines 601 - 620, The proto definitions for ComputeNetworkAttachment and BareMetalNetworkAttachment are missing the `primary` field that was introduced in the Multi-NIC Networking enhancement. Add a `bool primary` field to both message definitions with appropriate comments indicating it is optional and immutable, reflecting its purpose in the networking hierarchy. Consider adding a note that cross-references the Multi-NIC Networking enhancement documentation for the operational semantics of this field to ensure readers understand the complete picture.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@enhancements/multi-nic-networking/README.md`:
- Line 199: In the risk mitigation table on line 199 of the README file, correct
the spelling error in the "Service unreachable" cell where "unreachabl" is
misspelled. Change it to "unreachable" to ensure proper spelling in the
documentation table.
---
Outside diff comments:
In `@enhancements/unified-networking/README.md`:
- Around line 601-620: The proto definitions for ComputeNetworkAttachment and
BareMetalNetworkAttachment are missing the `primary` field that was introduced
in the Multi-NIC Networking enhancement. Add a `bool primary` field to both
message definitions with appropriate comments indicating it is optional and
immutable, reflecting its purpose in the networking hierarchy. Consider adding a
note that cross-references the Multi-NIC Networking enhancement documentation
for the operational semantics of this field to ensure readers understand the
complete picture.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: d1609f4b-c511-4816-a2b3-ee890bb00276
📒 Files selected for processing (2)
enhancements/multi-nic-networking/README.mdenhancements/unified-networking/README.md
…sign Adds primary network attachment field and multi-NIC behavior inline in the unified networking design doc (no separate enhancement file): - primary field on ComputeNetworkAttachment and BareMetalNetworkAttachment - Default gateway, DHCP, ExternalIPAttachment, and NATGateway semantics for multi-homed resources - Validation rules for primary designation - Cluster multi-NIC deferred to CaaS template Removes the separate multi-nic-networking enhancement directory. Signed-off-by: Dan Manor <dmanor@redhat.com>
danmanor
force-pushed
the
multi-nic-design
branch
from
2e549e7 to
760be23
Compare
adriengentil
left a comment
adriengentil
left a comment
There was a problem hiding this comment.
Looks good, thanks for the follow-up!
|
Thanks @danmanor ! |
4 participants
Summary
Follow-up to the Unified Networking Design (merged). Addresses the multi-NIC questions.
The unified networking enhancement defines the attachment types (
ComputeNetworkAttachment,BareMetalNetworkAttachment) and validation rules for multi-NIC, but defers the operational details. This enhancement defines:primary: truefield; determines default gateway, DNAT target, and SNAT sourceChanges
enhancements/multi-nic-networking/README.mdenhancements/unified-networking/README.md— references this enhancement for multi-NIC detailsSummary by CodeRabbit