Skip to content

Use ID_LIKE to figure out which bib file to use if a distro def doesn't exist.#1172

Open
PizzaLovingNerd wants to merge 3 commits intoosbuild:mainfrom
PizzaLovingNerd:main
Open

Use ID_LIKE to figure out which bib file to use if a distro def doesn't exist.#1172
PizzaLovingNerd wants to merge 3 commits intoosbuild:mainfrom
PizzaLovingNerd:main

Conversation

@PizzaLovingNerd
Copy link
Contributor

Also remove stillOS symlink as this commit removes the need for it.

I wanted to have a visible warning if this occurred, although I could not figure out how to display that in the CLI other than just adding it as a warning to the logs.

@PizzaLovingNerd PizzaLovingNerd requested a review from a team as a code owner December 30, 2025 04:56
@PizzaLovingNerd PizzaLovingNerd requested review from bcl, croissanne and supakeen and removed request for a team December 30, 2025 04:56
@supakeen supakeen self-assigned this Dec 31, 2025
Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have similar code elsewhere (which really means we should proceed with the merge) but for now @PizzaLovingNerd if you can address @bcl's comment this can go in :)

@PizzaLovingNerd
Copy link
Contributor Author

Just added BCL's suggestion, it will now log what it is trying if finds an ID_Like options. Sorry for the delay in the fix.

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@supakeen
Copy link
Member

supakeen commented Jan 9, 2026

Looks good, tests are failing due to: osbuild/images#2123 so let's have that merged first and then I'll retrigger them and this can go in.

Pull in upstream changes
@PizzaLovingNerd
Copy link
Contributor Author

I've just pulled in new commits to ensure everything is fresh. Since osbuild/images#2123 was merged, can you please re-trigger the tests? Thanks!

@supakeen
Copy link
Member

I've just pulled in new commits to ensure everything is fresh. Since osbuild/images#2123 was merged, can you please re-trigger the tests? Thanks!

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants