Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: switch to rhel-95, drop rhel-810 #2029

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

croissanne
Copy link
Member

@croissanne croissanne commented Aug 8, 2024

The rhel-9-4 and rhel-8-10 tests we should ignore, see cockpit-project/bots#6716

@croissanne croissanne changed the title test: rhel-95, drop rhel-810 test: switch to rhel-95, drop rhel-810 Aug 8, 2024
@croissanne croissanne marked this pull request as ready for review August 9, 2024 08:08
@kingsleyzissou
Copy link
Contributor

kingsleyzissou commented Aug 9, 2024

I mean it looks good to me, the tests failing is pretty weird though

Edit: I see you're still debugging though

@croissanne
Copy link
Member Author

I mean it looks good to me, the tests failing is pretty weird though

Edit: I see you're still debugging though

note that rhel 8-10 and 9-4 is expected to fail here, just fedora39/40, centos-9 and rhel-9-5 are meant to be green

@kingsleyzissou
Copy link
Contributor

note that rhel 8-10 and 9-4 is expected to fail here, just fedora39/40, centos-9 and rhel-9-5 are meant to be green

Thanks, I didn't realise that. But I guess I should have read the PR title properly

@kingsleyzissou
Copy link
Contributor

kingsleyzissou commented Aug 9, 2024

If we're dropping rhel-8-10 don't we want to remove it from the list of github actions too?

@croissanne
Copy link
Member Author

If we're dropping rhel-8-10 don't we want to remove it from the list of github actions too?

That's determined by cockpit-project/bots#6716, this gets green, we trigger the relevant tests on that PR, and rhel-8 and 94 won't be triggered anymore.

@kingsleyzissou
Copy link
Contributor

If we're dropping rhel-8-10 don't we want to remove it from the list of github actions too?

That's determined by cockpit-project/bots#6716, this gets green, we trigger the relevant tests on that PR, and rhel-8 and 94 won't be triggered anymore.

Thanks for the clarification, I missed the linked PR. Clearly out of it this morning

Searching for packages can take a long time.
@croissanne
Copy link
Member Author

@kingsleyzissou ok it's ready, was just a timeout on f39

Copy link
Contributor

@kingsleyzissou kingsleyzissou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@croissanne croissanne merged commit 73795c5 into osbuild:main Aug 9, 2024
12 of 14 checks passed
@croissanne croissanne deleted the test-fixes branch August 9, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants