build: integrate prepare source from composer #1476
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
|
Hey @croissanne and @ezr-ondrej this needs an attention - other PRs are failing because of a version requirement, I believe it is great time to fix prepare sources for once. There is a tread on |
|
|
||
| GOBIN=$TOOLS_PATH $GO_BINARY generate -x -mod=mod ./... | ||
| # Generate source (skip vendor/): | ||
| GOBIN=$TOOLS_PATH go generate -x ./cmd/... ./internal/... |
There was a problem hiding this comment.
The TOOLS_PATH will disappear once we upgrade to 1.24 which features the all new Go tool pinning feature. In short, external tools will be added to go.mod now ensuring we all are on the same version. Until then, this is I believe a good workaround for the time being.
lzap
force-pushed
the
prepare-source
branch
2 times, most recently
from
7031154 to
f76cb53
Compare
tools/prepare-source.sh
Outdated
| $GO_BINARY download | ||
| # Check latest Go version for the minor we're using | ||
| LATEST=$(curl -s https://endoflife.date/api/go/"${GO_MAJOR_VER}".json | jq -r .latest) | ||
| if test "$LATEST" != "go$GO_VERSION"; then |
There was a problem hiding this comment.
This doesn't work, I see the WARNING even tho we are on latest, I believe the issue is:
| if test "$LATEST" != "go$GO_VERSION"; then | |
| if test "$LATEST" != "$GO_VERSION"; then |
I noticed this automated PR failed:
#1475
This is a chance to integrate changes from composer which uses a new Go feature "toolbox", hopefully it will prevent from automated failures.