Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: integrate prepare source from composer #1476

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lzap
Copy link
Collaborator

@lzap lzap commented Feb 4, 2025

I noticed this automated PR failed:

#1475

This is a chance to integrate changes from composer which uses a new Go feature "toolbox", hopefully it will prevent from automated failures.

@lzap lzap requested a review from croissanne February 4, 2025 12:16
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@lzap lzap requested a review from ezr-ondrej February 7, 2025 08:31
@lzap
Copy link
Collaborator Author

lzap commented Feb 7, 2025

Hey @croissanne and @ezr-ondrej this needs an attention - other PRs are failing because of a version requirement, I believe it is great time to fix prepare sources for once.

There is a tread on #osbuild channel about this, this was merged into composer, then reverted by @achilleas-k and now the final version is heading in: osbuild/osbuild-composer#4600 also being integrated elsewhere: osbuild/weldr-client#155


GOBIN=$TOOLS_PATH $GO_BINARY generate -x -mod=mod ./...
# Generate source (skip vendor/):
GOBIN=$TOOLS_PATH go generate -x ./cmd/... ./internal/...
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TOOLS_PATH will disappear once we upgrade to 1.24 which features the all new Go tool pinning feature. In short, external tools will be added to go.mod now ensuring we all are on the same version. Until then, this is I believe a good workaround for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant