Team member changes #171
Team member changes #171
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the About section by adding new components for displaying lists of people, including previous staff and grad tech leads, and introduces alphabetical sorting to the listings.
- Adds a PrevStaff component to render sorted previous staff profiles.
- Updates the PrevGradTechLeads and CurrentGradTechLeads components to sort profiles alphabetically.
- Introduces a CurrentStaff component that appears to have inconsistencies.
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/people/PrevStaff/index.js | New component to display previous staff sorted by name. |
| src/components/people/PrevGradTechLeads/index.js | Updates to sort grad tech leads by name. |
| src/components/people/CurrentStaff/index.js | Intended to display current staff, but references previous staff data and component name. |
| src/components/people/CurrentGradTechLeads/index.js | Updates to sort current grad tech leads by name. |
Files not reviewed (5)
- docs/about/about.mdx: Language not supported
- src/data/people/currentGradTechLeads.json: Language not supported
- src/data/people/currentStaff.json: Language not supported
- src/data/people/prevGradTechLeads.json: Language not supported
- src/data/people/prevStaff.json: Language not supported
There was a problem hiding this comment.
Pull Request Overview
This PR updates the team member information displayed in the About section by adding and updating components to render lists of previous staff, previous graduate tech leads, current staff, and current graduate tech leads.
- Added new components to display previous staff and current team members.
- Applied alphabetical sorting to the team lists, with most components using .slice() to avoid in-place mutations.
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/people/PrevStaff/index.js | Introduces the PrevStaff component with sorting logic; note that .slice() is not applied before .sort(). |
| src/components/people/PrevGradTechLeads/index.js | Updates the sorting logic by applying .slice() before .sort(). |
| src/components/people/CurrentStaff/index.js | Introduces the CurrentStaff component with .slice() before .sort(). |
| src/components/people/CurrentGradTechLeads/index.js | Updates the sorting logic by applying .slice() before .sort(). |
Files not reviewed (5)
- docs/about/about.mdx: Language not supported
- src/data/people/currentGradTechLeads.json: Language not supported
- src/data/people/currentStaff.json: Language not supported
- src/data/people/prevGradTechLeads.json: Language not supported
- src/data/people/prevStaff.json: Language not supported
|
|
||
| return ( | ||
| <div className="staffGrid"> | ||
| {prevStaff.sort((a, b) => (a.name > b.name) ? 1 : (b.name > a.name) ? -1 : 0) |
There was a problem hiding this comment.
Consider using .slice() before .sort() to avoid mutating the original prevStaff array and to maintain consistency with the other team member components.
| {prevStaff.sort((a, b) => (a.name > b.name) ? 1 : (b.name > a.name) ? -1 : 0) | |
| {prevStaff.slice().sort((a, b) => (a.name > b.name) ? 1 : (b.name > a.name) ? -1 : 0) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Updated the list of People in the About section. Questions I have: