make harpoon-go-to
work when in harpoon-file
#14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
harpoon-go-to should work as expected inside harpoon-file
i think it would be good default behaviour to make
harpoon-go-to
also work as expected (to jump to the file associated with the number) when inside theharpoon-file
buffer of the project.since most users have bound
harpoon-go-to-1
etc. to a fixed keybind, which doesn't not work when inside theharpoon-file
.current erroneous behaviour
currently harpoon errors when trying this, since the file
HARPOON-CACHE-FILE/harpoon
doesn't exist. this happens because harpoon reads theHARPOON-CACHE-FILE
itself as a project and thus tries to open itsharpoon-file
, which obviously doesn't exist.(there was also a bug where
(eq major-mode 'harpoon-mode)
is called inside(with-temp-buffer)
and thus is alwaysnil
.)test it
follow these steps, one time with, and one time without the proposed changes:
1. navigate to an existing project
2. call
harpoon-toggle-file
3. call eg.
harpoon-go-to-1
and observe behaviour