Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count all blunders #255

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

MarcManiez
Copy link

@MarcManiez MarcManiez commented Jan 11, 2023

Hello team Otrego, and thank you for providing this library 🙏 . I've been using it on a project, and realized the blunder detection wasn't tracking black's blunders (only white's).

This code does a few things, in addition to fixing the above:

  • Refactors FindBlunders. Hopefully you find this useful, but I'm happy to change it back if needed
  • Adds an option to set the blunder threshold
  • Adds an option to filter blunders by color
  • Adds some test data: a game, and its analysis. This idea being to make testing for this feature a little easier to follow.
  • Adds a couple of tests:
    • one to check that all blunders are found, and
    • one to ensure the custom threshold works

Thanks for your review!

@MarcManiez MarcManiez requested a review from a team as a code owner January 11, 2023 06:32
@artasparks artasparks requested review from artasparks and removed request for a team January 11, 2023 19:50
@MarcManiez
Copy link
Author

@artemispax I noticed you assign yourself ❤️ ! Thank you, and looking forward to your comments 🙏

@artasparks
Copy link
Member

Work at Google has been wild recently. I'll get to this soon. Thanks for the PR

@MarcManiez
Copy link
Author

Hi @artemispax! How're things at Google? Have they slowed down any? I still think this PR could be a nice change 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants