Skip to content

Trim Server URL #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevebell117 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Trim Server URL #375

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7911215
Trim Server URL
stevebell117 Dec 14, 2020
6718850
Update Settings.tsx
stevebell117 Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/renderer/Settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,13 @@ function URLInput({ initialURL, onValidURL }: URLInputProps) {
}, [initialURL]);

function onChange(event: React.ChangeEvent<HTMLInputElement>) {
setCurrentURL(event.target.value);
let eventValue = event.target.value.trim();
Copy link

@DispatchCommit DispatchCommit Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since eventValue won't change, I think it should be a const instead of let.


if (validateURL(event.target.value)) {
setCurrentURL(eventValue);

if (validateURL(eventValue)) {
setURLValid(true);
onValidURL(event.target.value);
onValidURL(eventValue);
} else {
setURLValid(false);
}
Expand Down