Skip to content

allow stop test speaker #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
romainlq wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow stop test speaker #592

romainlq wants to merge 2 commits into from

Conversation

@romainlq
Copy link

@romainlq romainlq commented Jan 20, 2021 •
edited
Loading

I added the possibility to stop the test speaker as soon as it started playing.

Closes #591

@OhMyGuus
Copy link
Contributor

OhMyGuus commented Jan 22, 2021 •
edited
Loading

You should add:
audio.onended = () => { setPlaying(false); };
Because u forgot to reset the button when the sound stopped, for the rest nice.

@romainlq
Copy link
Author

romainlq commented Jan 28, 2021

thanks for the feedback @OhMyGuus !
It has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow to stop test speaker

2 participants

@romainlq @OhMyGuus