Improve factory definition to match core

outeredge · Dec 7, 2021 · 8e7d429 · 8e7d429
1 parent e0e0fd2
commit 8e7d429
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/Model/File/Storage/Synchronization.php b/Model/File/Storage/Synchronization.php
@@ -10,7 +10,7 @@ class Synchronization
     /**
      * @var BucketFactory
      */
-    protected $bucket;
+    protected $storageFactory;
 
     /**
      * File stream handler
@@ -20,11 +20,11 @@ class Synchronization
     protected $mediaDirectory;
 
     public function __construct(
-        DirectoryWrite $directory,
-        BucketFactory $bucket
+        BucketFactory $storageFactory,
+        DirectoryWrite $directory
     ) {
+        $this->storageFactory = $storageFactory;
         $this->mediaDirectory = $directory;
-        $this->bucket = $bucket;
     }
 
     /**
@@ -35,9 +35,14 @@ public function __construct(
      */
     public function synchronize($relativeFileName)
     {
-        $storage = $this->bucket->loadByFilename($relativeFileName);
-
+        /** @var $storage Bucket */
+        $storage = $this->storageFactory->create();
+        try {
+            $storage->loadByFilename($relativeFileName);
+        } catch (\Exception $e) {
+        }
         if ($storage->getId()) {
+            /** @var WriteInterface $file */
             $file = $this->mediaDirectory->openFile($relativeFileName, 'w');
             try {
                 $file->lock();