Auth methode #2
Auth methode #2
Conversation
| return -1; | ||
| } | ||
|
|
||
| if (strlen(e->ak) != AK_SIZE || strlen(e->sk) != SK_SIZE) { |
There was a problem hiding this comment.
I'm not sure what it would check, I already check that ak/sk are not null.
if the string lack a 0 termination, then there is already nothing I can do.
So adding those check would only be useful, if there is an non-null-terminated string that go beyond strsz.
but I'm not sure the positive of this would overcome the negative of adding a C11 functions that might be less supported than strlen. (C11 glibc support is not the same as C11 compiler support)
There was a problem hiding this comment.
I've made this issue outscale/osc-sdk-c#23
lib.c
Outdated
| } | ||
| } else if (e->auth_method == OSC_PASSWORD_METHOD) { | ||
| e->ak = getenv("OSC_LOGIN"); | ||
| e->sk = getenv("OSC_PASSWORD"); |
There was a problem hiding this comment.
could you use dedicated struct element like e->login and e->password to avoid confusion and future errors?
There was a problem hiding this comment.
I could but that would duplicate the code too.
i could use a
union {
char *ak;
char *login;
}but anonymous union are not C89 and header, try to be C89.
| } | ||
| curl_easy_setopt(e->c, CURLOPT_HTTPHEADER, e->headers); | ||
| curl_easy_setopt(e->c, CURLOPT_USERNAME, e->ak); | ||
| curl_easy_setopt(e->c, CURLOPT_PASSWORD, e->sk); |
There was a problem hiding this comment.
Even if e->auth_method == OSC_AKSK_METHOD ?
There was a problem hiding this comment.
yes, ak/sk use CURLOPT_USERNAME/CURLOPT_PASSWORD for the ak and sk.
the curl_easy_setopt(e->c, CURLOPT_AWS_SIGV4, "osc"); is for v4 specific arguments.
lib.h
Outdated
| @@ -69,13 +69,19 @@ struct osc_str { | |||
| #define OSC_API_VERSION "____api_version____" | |||
| #define OSC_SDK_VERSION ____sdk_version____ | |||
|
|
|||
| enum osc_auth_method { | |||
| OSC_AKSK_METHODE, | |||
lib.c
Outdated
|
|
||
| *password = NULL; | ||
| *email = NULL; | ||
| strcpy(stpcpy(buf, home), dest); |
There was a problem hiding this comment.
maybe check home size as buf is bounded to 1024
lib.c
Outdated
| if (auth && (!strcmp(auth, "password") || !strcmp(auth, "basic"))) | ||
| e->auth_method = OSC_PASSWORD_METHOD; | ||
| else if (auth && strcmp(auth, "accesskey")) { | ||
| fprintf(stderr, "'%s' invalude auth methode\n", auth); |
There was a problem hiding this comment.
-> invalid authentication method
outscale-mgo
force-pushed
the
aith_methode
branch
from
b2b99a6 to
4f6a652
Compare
outscale-mgo
force-pushed
the
master
branch
2 times, most recently
from
1f77882 to
8257245
Compare
Signed-off-by: Matthias Gatto <[email protected]>
outscale-mgo
force-pushed
the
aith_methode
branch
from
4f6a652 to
ac9abdd
Compare
No description provided.