Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go binary sbom #73

Merged
merged 6 commits into from
Mar 17, 2024
Merged

go binary sbom #73

merged 6 commits into from
Mar 17, 2024

Conversation

prabhu
Copy link
Member

@prabhu prabhu commented Mar 13, 2024

Refer to the changes in bintests but pretty much all go binaries are supported.

prabhu added 2 commits March 13, 2024 20:57
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu prabhu enabled auto-merge March 13, 2024 21:27
@prabhu prabhu requested a review from saketjajoo March 14, 2024 10:12
@timmyteo
Copy link
Collaborator

Hi @prabhu running this branch on Windows against the Windows syft binary .exe produces the following BOM. I am not seeing any of the expected dependencies.
bom.json

@prabhu
Copy link
Member Author

prabhu commented Mar 14, 2024

@timmyteo, thanks for reporting this bug. Please use the latest to test for all OS and compare against the official sbom published here

Signed-off-by: Prabhu Subramanian <[email protected]>
@timmyteo
Copy link
Collaborator

Syft Testing: Windows .exe is looking good now. I tried against the .deb file and the binary for darwin, and the outcome is not what I would have expected, see attached. Am I correct in directly testing these binary files?
linux_deb_bom.json
darwin_bom.json

README.md Outdated
- Go binaries

```shell
blint sbom -i /path/to/go binaries -o bom.json --deep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/path/to/go-binaries ?

@prabhu prabhu disabled auto-merge March 15, 2024 09:08
@prabhu
Copy link
Member Author

prabhu commented Mar 15, 2024

Syft Testing: Windows .exe is looking good now. I tried against the .deb file and the binary for darwin, and the outcome is not what I would have expected, see attached. Am I correct in directly testing these binary files? linux_deb_bom.json darwin_bom.json

deb file is not supported so use the .tar.gz versions. For darwin, the sbom generated looks good. Any ideas which components are missing when compared with the official sbom? Compare only the components and dependencies attributes in the sbom.

@timmyteo
Copy link
Collaborator

Nice work Prabhu! I didn't perform a complete 1:1 comparison as there are many dependencies in Syft, but I checked about 30 and all were in both SBOM as expected. I am thinking this is looking good.

@prabhu
Copy link
Member Author

prabhu commented Mar 15, 2024

@timmyteo, Thank you so much. Could you also recheck dotnet for any regressions since I changed the hash detection logic.

@timmyteo
Copy link
Collaborator

dotnet looks good still!

@prabhu prabhu enabled auto-merge March 16, 2024 08:52
@prabhu prabhu disabled auto-merge March 17, 2024 21:37
@prabhu prabhu merged commit 2bcaacb into main Mar 17, 2024
16 checks passed
@prabhu prabhu deleted the feature/go-binary branch March 17, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants