-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for removeFromGroup #33147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add a scenarios for:
- when the user and group exist, but the user is not in the group, and we try to remove them from the group.
- when the group exists but the user does not exist
9313f5c
to
831702a
Compare
Codecov Report
@@ Coverage Diff @@
## master #33147 +/- ##
=========================================
Coverage 64.12% 64.12%
Complexity 18720 18720
=========================================
Files 1184 1184
Lines 70437 70437
Branches 1270 1270
=========================================
Hits 45171 45171
Misses 24896 24896
Partials 370 370
Continue to review full report at Codecov.
|
831702a
to
5066fba
Compare
Then the command should have been successful | ||
And the command output should contain the text 'Member "brand-new-user" could not be found in group "new-group"' | ||
|
||
Scenario: admin tries to remove a user who does exit from an existing group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who does not exist
5066fba
to
cbee7cc
Compare
Backport on: #33152 |
Description
This PR adds more tests for cliProvisioning removeFromGroup using occ commands.
Related issue: #33052
How Has This Been Tested?
Locally
Types of changes
Checklist: