Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3/5) [nexus] Add CRUD implementations for Affinity/Anti-Affinity Groups #7445

Merged
merged 45 commits into from
Feb 21, 2025

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jan 30, 2025

Pulled out of #7076

Adds auth structures for Affinity/Anti-Affinity Groups, as well as datastore methods for implementing
CRUD (Create, Read, Update Delete) methods on these groups.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing too controversial here, and I like the large number of tests! I had a couple smallish thoughts I commented on.

Copy link
Contributor

@andrewjstone andrewjstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the comprehensive tests.

Base automatically changed from affinity-db-model to main February 21, 2025 04:36
@smklein smklein enabled auto-merge (squash) February 21, 2025 19:33
@smklein smklein merged commit 449effd into main Feb 21, 2025
16 checks passed
@smklein smklein deleted the affinity-db-crud branch February 21, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants