[multicast] Bump dendrite and remove unnecessary recovery path#9951
Draft
zeeshanlakhani wants to merge 1 commit intomainfrom
Draft
[multicast] Bump dendrite and remove unnecessary recovery path#9951zeeshanlakhani wants to merge 1 commit intomainfrom
zeeshanlakhani wants to merge 1 commit intomainfrom
Conversation
Open
1 task
zeeshanlakhani
changed the title
zeeshanlakhani
force-pushed
the
zl/dendrite-232
branch
from
cbc3a5d to
fe4cfdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches Dendrite PR oxidecomputer/dendrite#232 and slots after #9898.
This update dendrite rev to 5a4f56e (oxidecomputer/dendrite#232), which fixes the empty-transition in
modify_group_internal. With the fix, the delete+recreate recovery path inmodify_group_membershipis no longer needed. Errors now propagate directly and the reconciler handles drift on the next pass.