Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ability] Added Partial and TODO to Compound Eyes and Super Luck #1620

Closed
wants to merge 3 commits into from
Closed

[Ability] Added Partial and TODO to Compound Eyes and Super Luck #1620

wants to merge 3 commits into from

Conversation

EvasiveAce
Copy link
Contributor

@EvasiveAce EvasiveAce commented May 30, 2024

Just removed partial from Super Luck. It makes the ability look better, and the actual in battle ability does work as intended. Compound eyes is the exact same situation but does not have .partial().

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?
    • (it just removes (P))

@EvasiveAce EvasiveAce changed the title [Ability] Remove Partial from Super Luck and added TODO [Ability] Added Partial and TODO to Compound Eyes and Super Luck May 30, 2024
@OrangeRed
Copy link
Collaborator

Can you add the + 1 luck attr to this PR and rename it to include you did that?

@EvasiveAce
Copy link
Contributor Author

Can you add the + 1 luck attr to this PR and rename it to include you did that?

I will do a separate PR since it seems like a design type thing.

@EvasiveAce EvasiveAce closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants