[QoL] Auto center the window vertically #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dakurei
added
Enhancement
torranx
previously approved these changes
Jun 29, 2024
Dakurei
force-pushed
the
always-centered-landscape
branch
from
3272896 to
0e4c78a
Compare
Dakurei
force-pushed
the
always-centered-landscape
branch
from
0e4c78a to
7a01282
Compare
Dakurei
force-pushed
the
always-centered-landscape
branch
from
7a01282 to
b5d9cdd
Compare
Dakurei
force-pushed
the
always-centered-landscape
branch
from
b5d9cdd to
2bcf0de
Compare
torranx
approved these changes
Aug 31, 2024
DayKev
approved these changes
Aug 31, 2024
+ When the game is played in landscape format
or in portrait format when it's not a touchscreen
Dakurei
force-pushed
the
always-centered-landscape
branch
from
2bcf0de to
88d5dee
Compare
|
@Dakurei Are you still actively working on this? |
flx-sta
approved these changes
Sep 17, 2024
The fact is, it was all over the moment I created the PR xD I was just doing the occasional rebase & force push when I came across the tab and saw conflicts, but since you've passed the option to always be in sync with Beta's HEAD, I wasn't going to spend my life rebasing 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
Auto center the window vertically when the game is played in landscape format or in portrait format when touch controls are not displayed
Why am I doing these changes?
It was a request, and an old PR closed in advance in favor of this one (See #1114) (cc @torranx)
What did change?
CSS modification to achieve alignment without having to tweak any config in the game code directly
Screenshots/Videos
How to test the changes?
Launch from a mobile or using an adaptive browser view
Checklist
npm run test)