Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX] Fix showing form names and types #5302

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

Wlowscha
Copy link
Contributor

@Wlowscha Wlowscha commented Feb 11, 2025

What are the changes the user will see?

  • Form names are displayed properly
  • Form types are shown correctly when scrolling through the tray
  • Unobtainable forms are not shown

What are the changes from a developer perspective?

Added a new isUnobtainable attribute in PokemonForm which can be checked by the dex, so far given to forms of Marshadow, Arceus, Ploteageist and its prevolution.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

@Wlowscha
Copy link
Contributor Author

marshaloneee
arceus18

@Wlowscha Wlowscha marked this pull request as ready for review February 11, 2025 23:50
@Wlowscha Wlowscha requested a review from a team as a code owner February 11, 2025 23:50
@Madmadness65 Madmadness65 added the UI/UX User interface/-experience related label Feb 12, 2025
@damocleas damocleas merged commit 7199aee into pagefaultgames:beta Feb 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants