Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX] Valentine 2025 Event Banners #5310

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

Adri1
Copy link
Contributor

@Adri1 Adri1 commented Feb 13, 2025

What are the changes the user will see?

New banner for Valentine Event

  • English
  • French
  • German
  • Spanish
  • Italian
  • Portuguese
  • Japanese
  • Korean
  • Chinese

Screenshots:

image

image

Why am I making these changes?

To match the theme

What are the changes from a developer perspective?

None

How to test the changes?

Play the game while event timer activated

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Adri1 Adri1 added the UI/UX User interface/-experience related label Feb 13, 2025
@Adri1 Adri1 requested a review from a team as a code owner February 13, 2025 00:08
@Adri1 Adri1 changed the title [UI/UX ]Valentine 2025 Event Banners [UI/UX] Valentine 2025 Event Banners Feb 13, 2025
@Adri1 Adri1 marked this pull request as draft February 13, 2025 00:09
Madmadness65
Madmadness65 previously approved these changes Feb 13, 2025
@Madmadness65 Madmadness65 added the Event Adds or makes changes to limited-time events label Feb 13, 2025
@Adri1 Adri1 marked this pull request as ready for review February 13, 2025 11:53
@Adri1 Adri1 requested a review from Madmadness65 February 13, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event Adds or makes changes to limited-time events UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants