Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Clobbopus being unable to evolve before level 35 #5312

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

Fontbane
Copy link
Contributor

What are the changes the user will see?

  • Fixes an issue where Clobbopus was unable to evolve before level 35, even if it knew Taunt

Why am I making these changes?

What are the changes from a developer perspective?

  • Changes Clobbopus's evolution level to 1 and gives it SpeciesWildEvolutionDelay.LONG

Screenshots/Videos

How to test the changes?

ITEM_REWARD_OVERRIDE: [{ "name": "TM_GREAT", type: Moves.TAUNT }]
This will give you the TM for Taunt in your rewards. Start with Clobbopus and it should evolve by wave 5.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Fontbane Fontbane requested a review from a team as a code owner February 13, 2025 02:55
@Fontbane Fontbane changed the title [Bug] Fix Clobbopus being unable to evolve before lv 35 [Bug] Fix Clobbopus being unable to evolve before level 35 Feb 13, 2025
@damocleas
Copy link
Collaborator

Being able to luck into Grapploct super early is not desirable behavior

@damocleas damocleas added Game Balance Changes focused on game balance P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Feb 13, 2025
@Madmadness65 Madmadness65 added Game Balance Changes focused on game balance and removed Game Balance Changes focused on game balance labels Feb 13, 2025
@Blitz425
Copy link
Contributor

If this is how it works in mainline, I see absolutely no issue with this implementation

@Fontbane
Copy link
Contributor Author

Fontbane commented Feb 13, 2025

Being able to luck into Grapploct super early is not desirable behavior

How is that any different from lucking into an item evolution? This restriction is completely arbitrary and only present because Taunt used to be (N).

Copy link
Member

@SirzBenjie SirzBenjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise, looks good.

Not gonna comment on the balance considerations in my approval.

@EscaShark
Copy link
Contributor

Can you alter the PR to include every other mon where this applies as well? This is most visible on Clobbopus because Taunt is a TM, but technically all of these could get their moves earlier through fuse tutoring. I don't think splitting them all into different PRs is warranted when it's the same effective discussion every time.

It should also be noted that weirdly, Bonsly and Mime Jr. do evolve at any level despite not getting their evo moves at level 1, so I don't think this was ever a hard rule to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game Balance Changes focused on game balance P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants