[Ability][Bug] Remove partial designation from Quark Drive and Protosynthesis
#5315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damocleas
added
Ability
damocleas
approved these changes
Feb 13, 2025
damocleas
changed the title
partial designation from Quark Drive and Protosynthesispartial designation from Quark Drive and Protosynthesis
Wlowscha
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
The ( P ) designation is now removed from Quark Drive and Protosynthesis, as #5254 was merged.
There are no GitHub issues mentioning Quark Drive or Prosoynthesis to warrant the (P) designation staying.
Why am I making these changes?
The more things without the (P) and (N) designations, the better. It makes the game feel more complete.
What are the changes from a developer perspective?
Remove
.partial()insrc/data/moves.tsfrom Quark Drive and Protosynthesis.Screenshots/Videos
before
after
How to test the changes?
Look at a mon with quark drive and observe that it no longer has (P) on it.
Checklist
betaas my base branchnpm run test)[ ] Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?[ ] Have I made sure that any UI change works for both UI themes (default and legacy)?Are there any localization additions or changes? If so:[ ] Has a locales PR been created on the locales repo?[ ] If so, please leave a link to it here:[ ] Has the translation team been contacted for proofreading/translation?