Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move] Make Disable disable most recent move instead of oldest move #5321

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

Xavion3
Copy link
Contributor

@Xavion3 Xavion3 commented Feb 14, 2025

What are the changes the user will see?

Disable will disable the most recently used non-virtual move, instead of the oldest.

Why am I making these changes?

Fixes #5105

What are the changes from a developer perspective?

Tweaks the method used to apply disable

Screenshots/Videos

How to test the changes?

Run the automated tests, or set up overrides to test in game.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Xavion3 Xavion3 added Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Feb 14, 2025
@Xavion3 Xavion3 marked this pull request as ready for review February 14, 2025 05:03
@Xavion3 Xavion3 requested a review from a team as a code owner February 14, 2025 05:03
bavalpey
bavalpey approved these changes Feb 14, 2025
@SirzBenjie
Copy link
Member

SirzBenjie commented Feb 14, 2025

Wow totally forgot to swap accounts again 😅

Copy link
Member

@SirzBenjie SirzBenjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

I think similar logic should work for stomping tantrum and temper flare, neither of which seems to properly be considering the last move they used on the previous turn.

@Madmadness65 Madmadness65 changed the title Make disable disable most recent move instead of oldest move [Move] Make Disable disable most recent move instead of oldest move Feb 14, 2025
@Madmadness65 Madmadness65 merged commit 8864347 into pagefaultgames:beta Feb 18, 2025
13 checks passed
@Xavion3 Xavion3 deleted the disable-fix branch February 18, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Disable Selects First Move used by Target
5 participants