Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Hotfix] Fix fusion with dual type + monotype with shared primary type. #5322

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

Xavion3
Copy link
Contributor

@Xavion3 Xavion3 commented Feb 14, 2025

What are the changes the user will see?

Fusions work as normal again, allowing dual type + monotype with shared primary type to use the first pokemons dual typing.

Why am I making these changes?

#5229 accidentally broke this.

What are the changes from a developer perspective?

Screenshots/Videos

image

How to test the changes?

Fuse something like pidgey + rattata.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Xavion3 Xavion3 added the P2 Bug Minor. Non crashing Incorrect move/ability/interaction label Feb 14, 2025
@Xavion3 Xavion3 requested a review from a team as a code owner February 14, 2025 06:51
SirzBenjie
SirzBenjie previously approved these changes Feb 14, 2025
@damocleas damocleas merged commit 77fbcc7 into pagefaultgames:main Feb 14, 2025
14 checks passed
@Xavion3 Xavion3 deleted the Fusion-fix branch February 14, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants