-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Refactor] Remove main.ts default export, clean up manifest code
#6768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bertie690
wants to merge
8
commits into
pagefaultgames:beta
Choose a base branch
from
Bertie690:no-export-game
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DayKev
reviewed
Nov 9, 2025
Co-authored-by: NightKev <[email protected]>
Co-authored-by: NightKev <[email protected]>
Co-authored-by: NightKev <[email protected]>
Co-authored-by: NightKev <[email protected]>
Co-authored-by: NightKev <[email protected]>
DayKev
previously approved these changes
Nov 9, 2025
Collaborator
DayKev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also update scene-base.ts:
index 26a680f2162..3f04a48e2f4 100644
--- a/src/scene-base.ts
+++ b/src/scene-base.ts
@@ -18,12 +18,10 @@ export class SceneBase extends Phaser.Scene {
};
getCachedUrl(url: string): string {
- const manifest = this.game["manifest"];
- if (manifest) {
- const timestamp = manifest[`/${url}`];
- if (timestamp) {
- url += `?t=${timestamp}`;
- }
+ const { manifest } = this.game;
+ const timestamp = manifest?.[`/${url}`];
+ if (timestamp) {
+ url += `?t=${timestamp}`;
}
return url;
}
Contributor
Author
|
Sure - make the commit if you want or ill do it tmr maybe |
DayKev
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
N/A
Why am I making these changes?
game.manifestWhat are the changes from a developer perspective?
game.manifesttosrc/typings/phaser/index.d.tsand updated uses thereof to be correctglobalScene's manifest instead of having it slapped on during loading scene preload via a setterScreenshots/Videos
N/A
How to test the changes?
load game, make sure it runs
Checklist
betaas my base branchpnpm test:silent)