Make the nav menu scrollable#63
Open
ParadoxV5 wants to merge 1 commit into
Open
Conversation
for long menus and/or short-height windows/screens
|
Welcome! Congrats on your first pull request to the Leap Day theme. If you haven't already, please be sure to check out the contributing guidelines. |
|
@ParadoxV5 thanks for this! It works for me and I really needed it 👏 |
noyax
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
<nav>menu has many items (is long) or on short-height windows or screens, the<nav>simply overflows the window with the overflown items cut-off and inaccessible. This quick-fix proposal constraints the<nav>at thebottomand enables scrolling foroverflowbehaviour.Although, browsers’ – at least Chrome – scrollbars look thicc and out of place.
I discovered this oversight while trying to fix #48/#62. This can be an initiating step, as the next would be making the
bottomretract to make room for the<footer>(which has non-constant height, and I am not aware of how to respond to that).