Make usage of <code> in headers *not* ugly on small device screens#85
Open
toughengineer wants to merge 3 commits into
Open
Make usage of <code> in headers *not* ugly on small device screens#85toughengineer wants to merge 3 commits into
toughengineer wants to merge 3 commits into
Conversation
|
@toughengineer I stumbled on this PR and saw that there were failing checks, but I could not check. Maybe, you can add a commit to rigger the checks again? Update: Maybe the errors are because of #60 (comment)? |
Contributor
Author
|
@koppor, here you go. |
|
For the record, this is the error: |
Make usage of <code> in headers *not* ugly on small device screens
8ea8c12 to
e782b1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to
Make usage of <code> in headers not ugly #34
and fixes the issue for small screens.
The base font size is 14px, the size of
codeandpreelements is supposed to be 11px.11/14 = 0.7(857142857142), 0.7857 seems to be the good place to truncate it.
So for 14px base size
codeandpresize will be14px*0.7857 = 10,9998px which is very close to 11px.
Before the fix:

After the fix:
