completed onboarding #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegee
reviewed
Jan 20, 2017
| array_of_words.each do |word| | ||
| key = word.upcase.capitalize #downcase to prevent case mattering | ||
| if list.has_key? key #if word already exists, inc count | ||
| list["#{key}"]=list["#{key}"]+1 |
There was a problem hiding this comment.
Since key is a string, there's no need to interpolate it into a new string. "#{key}" is better written as key.
When you want to increment a value in Ruby, the typical syntax is: foo += 1.
Together: list[key] += 1
mikegee
reviewed
Jan 20, 2017
| #reads file in and returns array for printing | ||
| def generate_list filename | ||
| input = File.new filename, "r+" #opens file for reading | ||
| list = Hash.new #creates hash for wordcount list |
There was a problem hiding this comment.
You can instantiate Hashes with a default value that is used when a key is not found. Use Hash.new(0) here and you won't need to check if a given key is already in the hash when you need to increment its value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo