Complete task #101
Open
Complete task #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybobo
requested changes
May 10, 2018
| 'D' | ||
| elsif integer < 60 | ||
| 'F' | ||
| end | ||
| end | ||
|
|
||
| def shortest_string(array) |
There was a problem hiding this comment.
there's a few ways in ruby to complete this in a more concise way. try this one again using .min_by.
https://ruby-doc.org/core-2.5.0/Enumerable.html#method-i-min_by
letsdrill.rb
Outdated
|
|
||
| #Put your code here! | ||
|
|
||
| if integer >= 90 |
There was a problem hiding this comment.
if >= isn't sufficient and you need a 'lower bound', you can also use ranges
example:
case integer
when 80..90
...
end
|
I made the changes you recommended. |
mikegee
reviewed
May 14, 2018
|
|
||
| #Put your code here! | ||
|
|
||
| array.min_by(&:length) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo
Here you go!