Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done! :D #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Done! :D #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffbf5d5
Pass letter grade tests.
May 10, 2018
4e38c0f
Pass shortest string tests.
May 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions letsdrill.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,30 @@
def get_letter_grade(integer)

#Put your code here!

if integer >= 90
"A"
elsif integer < 90 && integer >= 80
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you go this route with a guard clause of sorts keep in mind that case statements and ranges are also an option.

case integer
when 80..90
  ...
end

"B"
elsif integer < 80 && integer >= 70
"C"
elsif integer < 70 && integer >= 60
"D"
else
"F"
end
end

def shortest_string(array)

#Put your code here!

array.sort_by {|word| word.length}.first
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'.min_by' is a handy little ruby function that will make this a bit more concise.

https://ruby-doc.org/core-2.5.0/Enumerable.html#method-i-min_by

end



### Don't touch anything below this line ###

p "Fetch Letter Grade: You should have 2 trues"
p get_letter_grade(89) == "B"
p get_letter_grade(73) == "C"
p get_letter_grade(89) == "B"
p get_letter_grade(73) == "C"
p
p "Shortest String: You should have 3 trues"
p shortest_string(["touch","this", "car"]) == "car"
p shortest_string([]) == nil
p shortest_string(["can", "a", "solve", "Find", "solution"]) == "a"
p shortest_string([]) == nil
p shortest_string(["can", "a", "solve", "Find", "solution"]) == "a"