Alex richards solution #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegee
reviewed
Jul 3, 2018
| end | ||
|
|
||
| def fetch_the_dog(input) | ||
| #implement your solution here | ||
| input.reject { |e| e != "dog" } |
There was a problem hiding this comment.
I think this returns an array with one element (the "dog"), but I wouldn't expect the result to be an array.
There was a problem hiding this comment.
Oops. I was wrong. Ignore that ^
Completely different nitpick: reject and != are both "negative" in a sense, making this a double negative in my opinion. Can this be rephrased positively?
mikegee
reviewed
Jul 3, 2018
challenge.rb
Outdated
| end | ||
|
|
||
| def fetch_the_first_two(input) | ||
| #implement your solution here | ||
| input[0,2] |
There was a problem hiding this comment.
This totally works and [] has great flexibility. input.first(2) would be clearer to the next reader, though.
…t method, but the instructions say that we can only use each method once. But now I realized I used the reject method twice anyways so it doesn't matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.