Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Tests Pass #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

All Tests Pass #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions challenge.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@

def capitalize_each_string(input)
#implement your solution here
input.map(&:capitalize)
end

def fetch_the_dog(input)
#implement your solution here
input.find_all {|animal| animal == "dog"}
end

def no_dogs_allowed(input)
#implement your solution here
input.reject {|animal| animal == "dog"}
end

def count_the_animals(input)
#implement your solution here
input.count
end

def fetch_the_first_two(input)
#implement your solution here
input.take(2)
end

def fetch_CD_animals(input)
#implement your solution here
input.grep(/^[cd]/i)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it hard on yourself! I like the creativity, before using a Regex, can you think of any other methods you might try?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially the use of input.select or input.find_all in order to locate the "c" or "d".

input.find_all {|animal| animal.start_with?('c', 'd')}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - What you did was fine, just wanted to suggest that regex aren't always the best solution even if they are very powerful (hard to read and maintain).

end

## DO NOT CHANGE CODE BELOW THIS LINE ##
Expand All @@ -29,7 +29,7 @@ def fetch_CD_animals(input)

p capitalize_each_string(animals) == ["Cat", "Moose", "Dog", "Bird"]

p fetch_the_dog(animals) == ["dog"]
p fetch_the_dog(animals) == ["dog"]

p no_dogs_allowed(animals) == ["cat", "moose", "bird"]

Expand Down