Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished parser #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Finished parser #34

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a85499
Finished parser
wesdelp Jun 1, 2016
b7bd6eb
Removed imlicit return
wesdelp Jun 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
def word_in_string?(word, string)
# implement with your code here
words = string.split(/[\s_\-.]/)
found = words.find { |w| w == word }
return found ? :yes : :no
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to break this up, bc at first glance this looks like you're returning found, and takes the reader a moment to recognize its ternary. Especially because you have symbols surrounding the : operator.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the explicit return might be sufficient to clarify it.

end